Remodel how analyzer dependencies are managed#1622
Merged
Conversation
This updates some dependencies, but more importantly it adopts the pattern in the vs-mef repo for how analyzer dependencies are expressed so that they don't accidentally get updated with other dependencies.
There was a problem hiding this comment.
Pull request overview
This PR updates Roslyn/analyzer-related dependencies and restructures how analyzer projects pin VS-host-compatible package versions by moving analyzer-specific overrides into a dedicated Directory.Packages.Analyzers.props, similar to the pattern used in vs-mef. It also updates affected code-fix rename calls to match the newer Roslyn API surface.
Changes:
- Bumped centrally-managed
Microsoft.CodeAnalysis*versions (general) and adjusted theMicrosoft.CodeAnalysis.ResxSourceGeneratorglobal reference. - Added
Directory.Packages.Analyzers.propsand conditionally imported it for analyzer projects ($(IsAnalyzerProject)), plus updated Renovate config to avoid updating that file. - Updated
Renamer.RenameSymbolAsyncinvocations to the newer overload shape.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.VisualStudio.Threading.Analyzers.CodeFixes/VSTHRD200UseAsyncNamingConventionCodeFix.cs | Adjusts Roslyn rename invocation to match updated Roslyn API usage. |
| src/Microsoft.VisualStudio.Threading.Analyzers.CodeFixes/FixUtils.cs | Adjusts Roslyn rename invocation to match updated Roslyn API usage. |
| Directory.Packages.props | Updates Roslyn package versioning and restructures analyzer-related pinning/refs. |
| Directory.Packages.Analyzers.props | Introduces analyzer-project-specific package version overrides (VS-host compatibility). |
| Directory.Build.targets | Imports analyzer-specific package overrides when IsAnalyzerProject is set. |
| .github/renovate.json | Disables Renovate updates for Directory.Packages.Analyzers.props. |
AArnott
force-pushed
the
dev/andarno/analyzer-dependencies
branch
from
bbd6cae to
ad30222
Compare
AArnott
force-pushed
the
dev/andarno/analyzer-dependencies
branch
from
ad30222 to
f86289b
Compare
AArnott
force-pushed
the
dev/andarno/analyzer-dependencies
branch
from
f86289b to
a71fbbb
Compare
olegtk
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates some dependencies, but more importantly it adopts the pattern in the vs-mef repo for how analyzer dependencies are expressed so that they don't accidentally get updated with other dependencies.